Add stash review support #1
Conversation
| @@ -20,7 +20,7 @@ | |||
|
|
|||
| "content_scripts": [ | |||
| { | |||
| "matches": ["*://bitbucket.org/*/pull-requests/*"], | |||
| "matches": ["<all_urls>"], | |||
There was a problem hiding this comment.
That won't work in current incarnation. The script will load for every page, which means it will measure time for every page and we don't want that.
There was a problem hiding this comment.
So I guess this would have to stay more or less open like this and we have to guard it in the script itself
|
|
||
| const url = new URL(window.location.href); | ||
| // example of URL to parse | ||
| // https://stash.clearcode.cc/projects/CCADS/repos/backend/pull-requests/137/commits |
There was a problem hiding this comment.
ok. Now I see that for hosted solutions it might work, but for custom ones like yours we should have configuration. And I should definitely add support for github so I will now how much time I have spent on this review
There was a problem hiding this comment.
👍 exactly. So this would require a bit of work on the configuration part.
|
OK, seems to be working fine. Please verify if this is what you requested. |
Extend plugin with stash support.
I had to make "matches" in
manifest.jsonreally open. Possibly can be done better than this.Unfortunately I'm getting 403 when pushing, maybe you could take a look into this.